Go: hashicorp/hcl models
#19806
Closed
Go: hashicorp/hcl models
#19806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds CodeQL extension models for the HashiCorp HCL packages, enabling taint tracking and source/sink identification in hcl and hclsimple.
- Introduce package grouping entries for
hcl1andhclsimple - Define sourceModel entries for
Decode/DecodeFilemethods - Add sinkModel and summaryModel entries to capture file inputs and taint propagation
Comments suppressed due to low confidence (2)
go/ql/lib/ext/github.com.hashicorp.model.yml:13
- The sourceModel entry for
hclsimple.DecodeFileusesArgument[2], butDecodeFileonly has two parameters (index 0 for the file path and index 1 for the destination). Update this toArgument[0]to correctly model the file input.
- ["group:hclsimple", "", False, "DecodeFile", "", "", "Argument[2]", "file", "manual"]
go/ql/lib/ext/github.com.hashicorp.model.yml:26
- The summaryModel entry for
hclsimple.DecodereferencesArgument[3], butDecodeonly takes two parameters (Argument[0]andArgument[1]). Verify the intended method and adjust the argument indices (or method name) to match the actual function signature.
- ["group:hclsimple", "", False, "Decode", "", "", "Argument[1]", "Argument[3]", "taint", "manual"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added models for the
github.com/hashicorp/hclpackages.